-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs #1372
Add docs #1372
Conversation
.github/workflows/release.yaml
Outdated
- name: Create Pull Request | ||
uses: peter-evans/create-pull-request@9825ae65b1cb54b543b938503728b432a0176d29 # v3 | ||
with: | ||
token: ${{ secrets.WEAVE_GITOPS_DOCS_WEAVEWORKS_DOCS_BOT_PAT }} | ||
token: ${{ secrets.WEAVEWORKS_DOCS_PR_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just keep using WEAVE_GITOPS_DOCS_WEAVEWORKS_DOCS_BOT_PAT
here?
The naming is a bit untidy but the bot might/should be able to create PRs on weave-gitops as its a member of weaveworks? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, I think we can, since that's listed as an organization token. I'll update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- staging looks good
- local dev looks good w/ GA_KEY set
Nicely done 💯
What changed?
Why?
How did you test it?
Release notes
Documentation Changes