Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs #1372

Merged
merged 21 commits into from
Feb 9, 2022
Merged

Add docs #1372

merged 21 commits into from
Feb 9, 2022

Conversation

luizbafilho
Copy link
Contributor

@luizbafilho luizbafilho commented Jan 31, 2022

What changed?

  • moving docs to this repo

Why?

How did you test it?

Release notes

Documentation Changes

@luizbafilho luizbafilho added the documentation Improvements or additions to documentation label Jan 31, 2022
- name: Create Pull Request
uses: peter-evans/create-pull-request@9825ae65b1cb54b543b938503728b432a0176d29 # v3
with:
token: ${{ secrets.WEAVE_GITOPS_DOCS_WEAVEWORKS_DOCS_BOT_PAT }}
token: ${{ secrets.WEAVEWORKS_DOCS_PR_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just keep using WEAVE_GITOPS_DOCS_WEAVEWORKS_DOCS_BOT_PAT here?

The naming is a bit untidy but the bot might/should be able to create PRs on weave-gitops as its a member of weaveworks? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, I think we can, since that's listed as an organization token. I'll update it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@luizbafilho luizbafilho requested a review from foot February 8, 2022 18:34
@luizbafilho luizbafilho marked this pull request as ready for review February 8, 2022 18:34
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • staging looks good
  • local dev looks good w/ GA_KEY set

Nicely done 💯

@luizbafilho luizbafilho merged commit 20b679b into main Feb 9, 2022
@luizbafilho luizbafilho deleted the add-docs branch February 9, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants