Tilt install fix #1374
Merged
Tilt install fix #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
approved these changes
Jan 31, 2022
|
Nice work @morancj ! |
aclevername
approved these changes
Feb 1, 2022
morancj
force-pushed
the
tilt-install-fix
branch
from
0acba92
to
84488b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1369
What changed?
Install tilt directly, rather than using
curl | bashWhy?
docker buildfails otherwise as it uses (not installed or configured)sudo.How did you test it?
Tested locally with
docker buildon Arch Linux & Mac OS, x86_64. I can't test themaketargets directly as they refuse to build in a clean chroot, and I don't currently have time to figure out which dependencies are missing.Release notes
Documentation Changes
Other
I am not familiar enough with your build env to determine which fix is correct: caa4975 or 0acba92.