Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the local build to install and configure tilt for first runners #1408

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Feb 8, 2022

Tilt install assume you already have a working cluster. That's not really needed.

Now that we have acceptance test change how we handle the image in the real deployment yaml file, we can bootstrap a dev environment and then let tilt take over so it monitors all files.

Screenshot 2022-02-08 at 12 53 25

This is now working with a booted up dev cluster from 0 -> 100 without running anything before hand just this:

TEST_CONFIG_REPO=ssh://git@github.com/Skarlso/gitops-training.git make cluster-dev

There is also a convenient make target to clean everything up: make clean-dev-cluster.

Question

Do people would like to have an option to disable the bootstrap part and still use tilt with an existing cluster?

Closes #1406

@Skarlso Skarlso added the type/enhancement New feature or request label Feb 8, 2022
@Skarlso Skarlso changed the title Fix the local build to install and configure tilt for first runners Modify the local build to install and configure tilt for first runners Feb 8, 2022
@nikimanoledaki
Copy link

awesome, trying it out now! could you also update/add instructions to the contributing guide please? :))

@Skarlso
Copy link
Contributor Author

Skarlso commented Feb 8, 2022

@nikimanoledaki You mean the README instructions here? https://github.com/weaveworks/weave-gitops/blob/main/README.md#cliapi-development :)

Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work

@Skarlso Skarlso merged commit ae9a360 into main Feb 8, 2022
@Skarlso Skarlso deleted the fix_tilt_missing_service_account branch February 8, 2022 19:06
@jpellizzari
Copy link
Contributor

jpellizzari commented Feb 9, 2022

@Skarlso Don't we also have to set the ports to 5001 in the ./tools/kind-with-registry script?

Showing this with docker ps:

3d9e0489d1a7   registry:2             "/entrypoint.sh /etc…"   3 weeks ago      Up 5 hours      0.0.0.0:5000->5000/tcp, :::5000->5000/tcp     kind-registry
fee7f3627648   registry:2             "/entrypoint.sh /etc…"   14 months ago    Up 5 hours      0.0.0.0:43645->5000/tcp, :::43645->5000/tcp   ctlptl-registry

And this in in tilt:

Build Failed: docker push: pushing image "localhost:5001/weaveworks/wego-app": Get "[http://localhost:5001/v2/":](http://localhost:5001/v2/) dial tcp [::1]:5001: connect: connection refused

@Skarlso
Copy link
Contributor Author

Skarlso commented Feb 9, 2022

You appear to have an old kind registry. Please delete it and try again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tilt up results in service account not found error in wego-app
3 participants