Add weave-gitops as a helm chart #1409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtparet
reviewed
Feb 9, 2022
| app: wego-app | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding |
There was a problem hiding this comment.
Should we use a ClusterRoleBinding ? When installing the chart we have currently in the logs :
E0209 15:49:45.385748 1 reflector.go:138] pkg/mod/k8s.io/client-go@v0.22.2/tools/cache/reflector.go:167: Failed to watch *v1beta1.HelmRepository: failed to list *v1beta1.HelmRepository: helmrepositories.source.toolkit.fluxcd.io is forbidden: User "system:serviceaccount:flux-system:wego-app-service-account" cannot list resource "helmrepositories" in API group "source.toolkit.fluxcd.io" at the cluster scope
There was a problem hiding this comment.
With a clusterrolebinding it is working.
I made a PR for change suggestions #1422
There was a problem hiding this comment.
@mtparet This a proof of concept idea but I did put up this draft pr and ask team members why I was getting this error. So thank you for helping out with that. Most likely the chart will not actually sit in this repo.
|
@J-Thompson12 are you actively taking this forwards? Or is this as far as you are going with this POC? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1379
What changed?
Added a chart to weave-gitops to allow installing weave-gitops as a helmrelease to existing flux.
Why?
How did you test it?
Release notes
Documentation Changes