Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seb change v2 check names #1411

Merged
merged 2 commits into from Feb 9, 2022
Merged

Seb change v2 check names #1411

merged 2 commits into from Feb 9, 2022

Conversation

sbernheim
Copy link
Contributor

Closes: Nothing

What changed?
Changing the name attribute values for the V2 GitHub Actions CI workflow and job.

Why?
Setting them to unambiguous values in order to figure out how those values must be represented in the repo's TF template branch protection rule statements.

How did you test it?
It needs to be tested on GitHub.

Release notes
Should not have any effect on the release.

Documentation Changes
No. These only apply to the GitHub actions and subsequently the TF templates for this repo.

Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Note for anyone else looking at this PR: we are trying to get the branch protection terraform rules right in weaveworks/corp

@sbernheim sbernheim merged commit 14fe67c into v2 Feb 9, 2022
@sbernheim sbernheim deleted the seb-change-v2-check-names branch February 9, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants