Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change kind-cluster script to bash #1413

Merged
merged 2 commits into from
Feb 9, 2022
Merged

change kind-cluster script to bash #1413

merged 2 commits into from
Feb 9, 2022

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Feb 9, 2022

STEP: Given I have a brand new cluster with a long cluster name
time="2022-02-09T10:56:11Z" level=info msg="Creating a kind cluster "
Create a new kind cluster with name 
./scripts/kind-cluster.sh: 22: [[: not found
Registry Host: kind-registry
ERROR: failed to create cluster: node(s) already exist for a cluster with the name "kind"
time="2022-02-09T10:56:11Z" level=info msg="Failed to create kind cluster"
time="2022-02-09T10:56:11Z" level=fatal msg="exit status 1"

https://github.com/weaveworks/weave-gitops/runs/5123765368?check_suite_focus=true

switching to bash should fix this. Also removes unneeded creating of a kind cluster in the buildup, since each test creates its own cluster

@aclevername aclevername force-pushed the bash-script branch 2 times, most recently from 4317bdd to 6e39426 Compare February 9, 2022 11:35
@aclevername aclevername merged commit 9bb316d into main Feb 9, 2022
@ozamosi ozamosi deleted the bash-script branch May 12, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants