use nightly-build wego-app image tag for nightly runs #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclevername
force-pushed
the
fix-nightly
branch
2 times, most recently
from
0e0e548
to
5e8948f
Compare
Skarlso
reviewed
Feb 10, 2022
aclevername
force-pushed
the
fix-nightly
branch
from
0eeb5a7
to
4dac11c
Compare
aclevername
force-pushed
the
fix-nightly
branch
from
705bf20
to
c9e0a0e
Compare
Skarlso
approved these changes
Feb 10, 2022
Skarlso
reviewed
Feb 10, 2022
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: weaveworks/wego-app | ||
| USE_NIGHTLY_BUILD_TAG: "true" |
There was a problem hiding this comment.
One small nit. Can we have this as 1 and then just check that it's set? There is usually no point in doing a string "true" in bash. :)
There was a problem hiding this comment.
Oh right, you are already doing this:
} else if os.Getenv("USE_NIGHTLY_BUILD_TAG") != "" {
version = "nightly-build"
}so just set it to 1. :)
Skarlso
reviewed
Feb 10, 2022
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGE_NAME: weaveworks/wego-app | ||
| USE_NIGHTLY_BUILD_TAG: "true" |
There was a problem hiding this comment.
Suggested change
| USE_NIGHTLY_BUILD_TAG: "true" | |
| USE_NIGHTLY_BUILD_TAG: 1 |
aclevername
force-pushed
the
fix-nightly
branch
from
c9e0a0e
to
0e69c76
Compare
added 8 commits
February 10, 2022 15:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1421
example run: https://github.com/weaveworks/weave-gitops/runs/5138673832?check_suite_focus=true