Cleanup version #1435
Merged
Cleanup version #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhwthompson
reviewed
Feb 11, 2022
There was a problem hiding this comment.
The code changes look good to me. Always nice to see how even a small change allows a bunch of complexity to fall out of the code.
Before we merge this, could you add a bit more context (either into the PR description or the Git commit messages) as to why we’re making this change? I know we understand it now, but our future selves (or other team members) might need a bit more to go on.
dhwthompson
approved these changes
Feb 14, 2022
jpellizzari
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Remove flux version check on version cmd * update fake flux Co-authored-by: Justin Thompson <jpthomp12@gmail.com>
jpellizzari
pushed a commit
that referenced
this pull request
Mar 3, 2022
* Remove flux version check on version cmd * update fake flux Co-authored-by: Justin Thompson <jpthomp12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Removes the flux version check when running
gitops versioncommand. We are removing the flux binary from weave-gitops so as part of decoupling flux and gitops we need to remove the checks on flux.Why?
How did you test it?
Release notes
Documentation Changes