Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Credentials from the HelmRepository #1438

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Pass Credentials from the HelmRepository #1438

merged 1 commit into from
Feb 14, 2022

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Feb 14, 2022

Closes #1166

@Skarlso Skarlso added type/enhancement New feature or request team/pitch-black labels Feb 14, 2022
hiddeco
hiddeco approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐧💨

@Skarlso Skarlso merged commit 14800da into main Feb 14, 2022
@Skarlso Skarlso deleted the pass_creds_profiles_api branch February 14, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

@aclevername aclevername aclevername approved these changes

@yiannistri yiannistri Awaiting requested review from yiannistri

@foot foot Awaiting requested review from foot

@nikimanoledaki nikimanoledaki Awaiting requested review from nikimanoledaki

Assignees
No one assigned
Labels
team/pitch-black type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiles API should inherit PassCredentials
3 participants
@Skarlso @hiddeco @aclevername