Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pend failing smoke test #1458

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Pend failing smoke test #1458

merged 2 commits into from
Feb 16, 2022

Conversation

Himangini
Copy link
Contributor

Closes:

What changed?
Pended the failing smoke test on main SmokeTestLong - Verify that gitops can deploy multiple apps one with private and other with public repo (e2e flow)

Why?
Main is broken

How did you test it?
NA

Release notes
NA

Documentation Changes
NA

@Himangini Himangini self-assigned this Feb 16, 2022
@Himangini Himangini added the bug Something isn't working label Feb 16, 2022
@rokshana-b rokshana-b added exclude from release notes and removed bug Something isn't working labels Feb 16, 2022
@Himangini Himangini changed the title Pending failing smoke test Pend failing smoke test Feb 16, 2022
@rokshana-b
Copy link
Contributor

@Himangini The tests that are getting pended - the issue with both seems to be wait time. Can we increase the wait time instead of pending them?

@Himangini
Copy link
Contributor Author

@Himangini The tests that are getting pended - the issue with both seems to be wait time. Can we increase the wait time instead of pending them?

@rokshana-b I think this should happen as a part of #1456 and other related issues. I don't have much context and I don't know what should the ideal timeout be.

@rokshana-b
Copy link
Contributor

@rokshana-b I think this should happen as a part of #1456 and other related issues. I don't have much context and I don't know what should the ideal timeout be.

I'll open a separate PR to fix the timeout issues

@Himangini Himangini merged commit 395d1a6 into main Feb 16, 2022
@ozamosi ozamosi deleted the pend-broken-smoke-test branch May 12, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants