Add Collapsible Search Input #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
approved these changes
Feb 17, 2022
| const CollapsibleInput = styled(Input)` | ||
| max-width: 0px; | ||
| overflow: hidden; | ||
| transition: max-width 0.5s ease; |
ui/components/SearchInput.tsx
Outdated
| onChange={(e: React.ChangeEvent<HTMLInputElement>) => | ||
| setSearch(e.target.value) | ||
| } | ||
| placeholder="NAME" |
There was a problem hiding this comment.
Probably don't want this to be the default.
jpellizzari
pushed a commit
that referenced
this pull request
Feb 25, 2022
* created collapsed input * resolve icon conflict
jpellizzari
pushed a commit
that referenced
this pull request
Mar 3, 2022
* created collapsed input * resolve icon conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-02-17.at.10.29.21.AM.mov
Hey team - is this how we're envisioning the search input?
Jordan - is it worth abstracting out the icon and expand-direction portions of this component to make it more reusable?
Ignore the story description I fixed it already 馃尀