Resolve wait times issues for tests #1470
Conversation
There was a problem hiding this comment.
So, it looks like this PR does four things:
- Raise the timeout for
gitAddCommitPushfrom 10 seconds to 30 - Raise the timeout for app deletion to 60 seconds in the cases where it was 30 seconds
- Remove the parameter to customize that timeout, as it’s always the same now
- Re-enable the disabled tests
Is that right? I’m just trying to make sure I’m following along correctly.
Also, do you have a guess how much difference this will make to how long the acceptance tests take to run? I see they took about 30–35 minutes on this PR, which seems on the upper end of what we were seeing already, but I appreciate that these times aren’t always super consistent.
|
@dhwthompson you are right about the 4 points, that's exactly what I'm doing.
I did see the longer run time but re-enabling the tests means there's 3 more tests running now compared to the last runs. So, I don't think this will make any significant impact overall because the functions are written to quit polling as soon the conditions become true. Therefore, tests will run as per usual time - they'll just stop failing(hopefully) due to quicker timeouts. |
What changed?
A couple of the acceptance tests were failing due to short waits. I've increased the wait time to a reasonable amount and removed skip tag from those failing tests.
Why?
GitOps takes around 60s to reconcile — so I've set the wait time to that.