Update cluster cmd #1487
Merged
Update cluster cmd #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Thompson12
force-pushed
the
update-cluster-cmd
branch
from
378d05b
to
22d786a
Compare
yiannistri
reviewed
Feb 23, 2022
cmd/internal/provider.go
Outdated
| } | ||
|
|
||
| token = generatedToken | ||
| return "", fmt.Errorf(missingTokenErr, tokenVarName) | ||
| } else if err != nil { |
There was a problem hiding this comment.
Is this redundant because we've already checked for err above? 🤔
There was a problem hiding this comment.
The above just gets the env var name. So GITHUB vs GITLAB. The second one checks if that var is empty or not.
There was a problem hiding this comment.
But lookupEnvFunc doesn't set err, so this case is still pointless, right? It was redundant before too, though.
There was a problem hiding this comment.
Oh yeah I looked at the wrong err. Yeah this is redundant.
ozamosi
approved these changes
Feb 23, 2022
yiannistri
approved these changes
Feb 24, 2022
jpellizzari
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Remove auth flow from cluster add/delete * fix lint error * remove redundant code Co-authored-by: Justin Thompson <jpthomp12@gmail.com>
jpellizzari
pushed a commit
that referenced
this pull request
Mar 3, 2022
* Remove auth flow from cluster add/delete * fix lint error * remove redundant code Co-authored-by: Justin Thompson <jpthomp12@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Removed the auth flow from cluster add/delete cmd's. Core is removing git auth but enterprise still needs a git token to create PR's. For now I have left in getting the token from the env variable. I also left in all the code for gitProvider. It isnt needed for add/delete but profiles is using it and that is a problem for another task.
Why?
How did you test it?
Release notes
Documentation Changes