Added validation to registry script #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the tilt build locally * Updated the manifest url for the localhost docker image * fix the port inside for kind to pull from # Conflicts: # Makefile # pkg/models/manifest.go
…ight mapping ports configuration
josecordaz
force-pushed
the
tilt-fixes
branch
from
cb76651
to
9551746
Compare
jpellizzari
approved these changes
Feb 23, 2022
| right_mapping_ports="5000/tcp -> 127.0.0.1:${reg_port}" | ||
| registry_port=$(docker port ${reg_name}) | ||
| if [ "${registry_port}" != "${right_mapping_ports}" ]; then | ||
| echo "It seems the current registry is running on different port configuration than expected:\n\n Current => ($registry_port) \n Expected ($right_mapping_ports). \n\nTry deleting registry manually using 'docker rm -f $reg_name' " |
jpellizzari
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Fix the tilt build locally (#1403) * Fix the tilt build locally * Updated the manifest url for the localhost docker image * fix the port inside for kind to pull from # Conflicts: # Makefile # pkg/models/manifest.go * Adding validation to make sure the current registry running has the right mapping ports configuration Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
jpellizzari
pushed a commit
that referenced
this pull request
Mar 3, 2022
* Fix the tilt build locally (#1403) * Fix the tilt build locally * Updated the manifest url for the localhost docker image * fix the port inside for kind to pull from # Conflicts: # Makefile # pkg/models/manifest.go * Adding validation to make sure the current registry running has the right mapping ports configuration Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
What changed?
Why?
How did you test it?
Release notes
Documentation Changes