Rate limit login requests #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
force-pushed
the
rate-limit-login
branch
from
f91be41
to
e8ec89e
Compare
foot
reviewed
Feb 24, 2022
| return err | ||
| } | ||
|
|
||
| middleware, err := httplimit.NewMiddleware(store, httplimit.IPKeyFunc()) |
yiannistri
force-pushed
the
rate-limit-login
branch
from
e8ec89e
to
822c539
Compare
yiannistri
force-pushed
the
rate-limit-login
branch
from
822c539
to
cbe2890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1090
What changed?
Added basic rate limit for requests to
/sign_inendpointWhy?
To protect the endpoint from a high volume of login attempts
How did you test it?
Manually
Release notes
N/A
Documentation Changes
N/A