Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitRepositoryDetail page #1522

Merged
merged 4 commits into from Feb 25, 2022
Merged

Add GitRepositoryDetail page #1522

merged 4 commits into from Feb 25, 2022

Conversation

jpellizzari
Copy link
Contributor

Part of #1520

A GitRepo that is working:
Screenshot from 2022-02-24 12-33-59

One that is in an error state:
Screenshot from 2022-02-24 12-34-10

@jpellizzari jpellizzari marked this pull request as ready for review February 24, 2022 21:43
joshri
joshri approved these changes Feb 24, 2022
View reviewed changes
ui/components/InfoList.tsx Show resolved Hide resolved
ui/components/SourceDetail.tsx Show resolved Hide resolved
ui/pages/v2/GitRepositoryDetail.tsx Show resolved Hide resolved
@jpellizzari jpellizzari mentioned this pull request Feb 25, 2022
Closed
@jpellizzari jpellizzari merged commit 0fc37a2 into v2 Feb 25, 2022
@jpellizzari jpellizzari deleted the 1520-source-detail branch February 25, 2022 22:39
@bia
Copy link

bia commented Feb 28, 2022

Looking good.

Two nits that I don't know if it's worth opening an issue over :

  • The distance between h1 and h2 should be 12px, between h2 and the info boxes should be 24px
  • h2 as well as the semibold field names ("URL:") should be Neutral 30, #737373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshri joshri joshri approved these changes

@bia bia Awaiting requested review from bia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpellizzari @bia @joshri