Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a RoleBinding for User: admin #1524

Merged
merged 6 commits into from Feb 28, 2022
Merged

Add a RoleBinding for User: admin #1524

merged 6 commits into from Feb 28, 2022

Conversation

sarataha
Copy link
Contributor

@sarataha sarataha commented Feb 24, 2022 •
edited

Closes: weaveworks/weave-gitops-enterprise#507

What changed?
Added a default rolebinding for admin user.

Why?
To give access rights to user admin when logging in with the superuser, as user doesn't have any roles currently.

How did you test it?
Tested manually.

Release notes

Documentation Changes

@sarataha sarataha added the type/enhancement New feature or request label Feb 24, 2022
@yiannistri yiannistri mentioned this pull request Feb 25, 2022
Merged
yiannistri
yiannistri reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter that this role binding has the same name as an existing one ? 🤔

I tried locally against a kind cluster and I can't see this role binding. Not sure if I'm missing something.

yiannistri
yiannistri approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sarataha sarataha merged commit c4b7b70 into main Feb 28, 2022
@sarataha sarataha deleted the admin-rolebinding branch February 28, 2022 14:13
@Callisto13 Callisto13 mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiannistri yiannistri yiannistri approved these changes

Assignees
No one assigned
Labels
type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When logging in w/ the superuser, (admin) you don't have any roles / ability to do anything
2 participants
@sarataha @yiannistri