Adjust Nav Styling #1525
Merged
Adjust Nav Styling #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
reviewed
Feb 24, 2022
ui/pages/v2/Sources.tsx
Outdated
| @@ -17,7 +17,7 @@ function SourcesList({ className }: Props) { | |||
| loading={isLoading} | |||
| className={className} | |||
| > | |||
| <SourcesTable sources={sources} /> | |||
| <SourcesTable sources={sources || []} /> | |||
There was a problem hiding this comment.
This looks like a leaky abstraction. Can we make <SourcesTable /> handle undefined instead?
There was a problem hiding this comment.
I'm going to remove this and handle it when I do the filtering. It has nothing to do with the Nav I was just checking out the errors
|
@jpellizzari good call out on the grouping together - I missed that. Sub menu item font I think needs to go from 600 - 400 font weight based on figma |
|
FIXED |
jpellizzari
approved these changes
Feb 25, 2022
ui/components/Layout.tsx
Outdated
| /> | ||
| {_.map(n.subItems, (sub) => { | ||
| return ( | ||
| <StyleLinkTab |
There was a problem hiding this comment.
Looking at Figma, sub items should be 12px below the main one. This looks a like a little bigger gap.
|
FIXED AGAIN |
jpellizzari
approved these changes
Feb 25, 2022
jpellizzari
added a commit
that referenced
this pull request
Mar 3, 2022
* fix logo text and bg, initial tabs work wrestling with mui * nav styles * snapshots updated * Set font-weight on .sub-items * nav spacing and font weight * remove dupe * brought indicator back * brought back proper spacing with new structure for indicator Co-authored-by: Jordan Pellizzari <jordan@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1459
All you have to do to make a Nav Item gray is add the key/value
{sub: true}to the navItems object array.Also did some fixes for the logo, background, and border radius on main containers.