Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exports #1528

Merged
merged 13 commits into from
Feb 25, 2022
Merged

Add exports #1528

merged 13 commits into from
Feb 25, 2022

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Feb 25, 2022 •
edited
Loading

What changed?

  • Added more exports needed in EE
  • Updated loading for auth
  • Updated parcel (SVGs not being bundled properly)

@AlinaGoaga AlinaGoaga marked this pull request as ready for review February 25, 2022 15:01
jpellizzari
jpellizzari approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AlinaGoaga
Copy link
Contributor Author

Hey @jpellizzari! Would you mind having a look at this when you get the chance please? It's all working fine (tested it in EE also), I'm just having issues with CI, getting npm ERR! qs not accessible from @storybook/store:@storybook/router on running npm ci. Have you guys seen this before? Simon's off so I am missing a React buddy over here. Thanks!

@AlinaGoaga AlinaGoaga merged commit 05f9b69 into main Feb 25, 2022
@AlinaGoaga AlinaGoaga deleted the add-exports branch May 9, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

Assignees
No one assigned
Labels
exclude from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlinaGoaga @jpellizzari @foot