Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean makefile #1532

Merged
merged 4 commits into from
Mar 2, 2022
Merged

Clean makefile #1532

merged 4 commits into from
Mar 2, 2022

Commits on Mar 2, 2022

  1. Check programs exist before calling them in vars 

    This should surpress warnings when building UI components without go
installed.
    Sam Cook committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    c39bce5 View commit details
    Browse the repository at this point in the history

  2. Remove un-needed ui makefile targets. 

    The `cmd/gitops/ui/run/dist/{,index.html}` targets create an empty
directory and file respectively and are only used in github workflows to
avoid git errors due to missing embed targets. This removes them in
favour of making it clear in the github actions that nothing is actually
being made.

This also re-orders the dependencies for the ui-lib target within the
makefile to make it clearer what lives with what
    Sam Cook committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b9de73f View commit details
    Browse the repository at this point in the history

  3. Document requirements in README 

    We should be clear about the tools used to build gitops
    Sam Cook committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    7857b90 View commit details
    Browse the repository at this point in the history

  4. Tidy up use of make cmd/gitops/... & touch 

    Some common patterns in the github workflows is to either create a fake
ui dist or flux file (`mkdir ... && touch ...`) or to run `npm ci` then
separately generate the ui. The former can now be removed as the
directories to be embedded have had keep files added while the latter
can be replaced with the simple `make ui` which performs all necessary
steps to generate the ui.
    Sam Cook committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    170275c View commit details
    Browse the repository at this point in the history