Fix a couple of docker target problems #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2022 13:24
Should this target exist? Not sure. However, this target does exist, is pulled in by the acceptance test target automatically, and it was broken. So fix it. What this target used to do differently from the default targets was to tag the image with an internal name instead of a public one. Should this distinction exist? Not sure. However, as both targets exist, I'll restore the distinction, too.
JamWils
approved these changes
Feb 28, 2022
jpellizzari
pushed a commit
that referenced
this pull request
Mar 3, 2022
* Fix `make local-docker-image` after docker file rename Should this target exist? Not sure. However, this target does exist, is pulled in by the acceptance test target automatically, and it was broken. So fix it. What this target used to do differently from the default targets was to tag the image with an internal name instead of a public one. Should this distinction exist? Not sure. However, as both targets exist, I'll restore the distinction, too. * Fix which docker image needs to embed flux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
make local-docker-imageFix default docker registry
Fix which image has the FLUX_VERSION argument sent to it