Move Breadcrumbs and reconfigure for V2Routes #1550
Conversation
| }, | ||
| { | ||
| label: "Namespace", | ||
| value: "namespace", | ||
| sortType: SortType.string, | ||
| sortValue: ({ namespace }) => namespace, |
There was a problem hiding this comment.
No longer necessary, right?
There was a problem hiding this comment.
My branch was out of date :( will fix
There was a problem hiding this comment.
ALSO - noticed a problem with this - right now DataTable is using the field having a SortType as an indication of whether it's sortable or not - we need a different indication of which columns are sortable
There was a problem hiding this comment.
@joshri Still not fixed?
ui/components/AutomationsTable.tsx
Outdated
| @@ -47,22 +46,6 @@ function AutomationsTable({ className, automations }: Props) { | |||
| label: "Namespace", | |||
| value: "namespace", | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I would not have expected these fields to change?
There was a problem hiding this comment.
Me neither put it back - I might have changed it trying to get the table to not break
| }, | ||
| { | ||
| label: "Namespace", | ||
| value: "namespace", | ||
| sortType: SortType.string, | ||
| sortValue: ({ namespace }) => namespace, |
There was a problem hiding this comment.
@joshri Still not fixed?
| @@ -41,6 +42,24 @@ export const getParentNavValue = ( | |||
| } | |||
| }; | |||
|
|
|||
| export const getPageLabel = (currentPage: string): string => { | |||
| const parsed = qs.parse(useLocation().search); | |||
There was a problem hiding this comment.
🤔 Not sure how this is working. I was under the impression that you cannot call hooks from plain old JS like this. I thought it had to be within another hook.
There was a problem hiding this comment.
Me too but it works so I'm not asking questions
* breadcrumbs * leftover in app context * conflicts cleanup * pr feedback * small cleanups
Closes: #1509
Adds Breadcrumbs component, and should also fix some errors caused by data tables mixing with the new sorting pr.