Add source pages #1553
Add source pages #1553
Conversation
jpellizzari
force-pushed
the
1526-source-pages
branch
from
3f6402e
to
de538e1
Compare
jpellizzari
force-pushed
the
1526-source-pages
branch
from
de538e1
to
b9cc851
Compare
|
|
||
| export default styled(Heading).attrs({ className: Heading.name })` | ||
| font-size: 20px; | ||
| `; |
There was a problem hiding this comment.
Is the Text component not flexible enough for this?
There was a problem hiding this comment.
It is semantically different. <Text /> is just a <span />. We want the actual <h1 />, <h2 /> etc tags to be there.
There was a problem hiding this comment.
Why? It is a semantically different component. I would want all Heading components to have similar styling. I wouldn't want the user to be able to specify bold or not bold, for example. I want all h1 to be bold.
I can make Heading wrap <Text />. Would that work?
There was a problem hiding this comment.
I just don't like that it leads to a lot of extra styling for a component where essentially the only thing that changes is the tag - I thought as made it show up semantically?
There was a problem hiding this comment.
I am saying it is a different "module" of code. They do different things. I don't want someone to be able to change the styling of a <Heading /> the same way they can of <Text />. <Heading /> is a way to enforce consistency in this case.
ui/components/SourceDetail.tsx
Outdated
| font-size: 20px; | ||
| margin-bottom: 12px; | ||
| } | ||
|
|
||
| h3 { |
There was a problem hiding this comment.
what makes this different from <Text fontSize='medium' color='neutral30' /> or something like that
jpellizzari
force-pushed
the
1526-source-pages
branch
from
b9cc851
to
bfb57cc
Compare
|
@joshri Added some logic to the |
jpellizzari
force-pushed
the
1526-source-pages
branch
2 times, most recently
from
921c9f5
to
13947c0
Compare
jpellizzari
force-pushed
the
1526-source-pages
branch
from
13947c0
to
63e4352
Compare
Closes #1526
Closes #1520
Adds some new sources:
Bucket:
Helm
Repo (chart was removed, doesn't seem like flux supports it?)