Fix KubeStatusIndicator overflow and color #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshri
approved these changes
Mar 3, 2022
|
@jpellizzari @joshri The status and message (applied revision) are shown in the top right of the page according to the designs. (If I'm recalling correctly - please double check!) |
That has changed since we implemented the page. I leaving as is for now, with the assumption that we sync up the UI with the MVP designs when they are rubber stamped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1593
Closes #1586
Closes #1585
Fixes the color and bold-ness of the status indications:
Also fixes the overflow when they are shown in a table:
Moves
Applied Revisionto the Info section for better consistency: