fix: smooth out v2 dev process #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a "finished product", I am simply doing the bare minimum to unblock people and make life easier while I tidy some things up. Here I am just adding some more manifests to the Tiltfile; I have stashed these in `tools/dev-manifests` for now, but this may change. Either way people will not notice as they are just running `make cluster-dev`. The manifests under `manifests/wego-dev` are technically out of use as we move onto a Helm Chart install flow, but I am leaving them there for now as I tinker, plus I know other people are working on the Helm bit so I am staying out of their way. I have also left the SuperUser and the "stripping out the service account" bit for now, as they do not need to be in place to unblock people. They are next on my list.
Callisto13
force-pushed
the
hotfix-dev-flow
branch
from
51b6480
to
28cddb8
Compare
yitsushi
approved these changes
Mar 4, 2022
| verbs: [ "list", "get" ] | ||
| - apiGroups: ["kustomize.toolkit.fluxcd.io"] | ||
| resources: [ "kustomizations" ] | ||
| verbs: [ "*" ] |
There was a problem hiding this comment.
isn't * too broad? We have only read operations on our short term roadmap and removed everything that would write.
| verbs: [ "*" ] | ||
| - apiGroups: ["helm.toolkit.fluxcd.io"] | ||
| resources: [ "helmreleases" ] | ||
| verbs: [ "*" ] |
| verbs: [ "*" ] | ||
| - apiGroups: ["source.toolkit.fluxcd.io"] | ||
| resources: [ "buckets", "helmcharts", "gitrepositories", "helmrepositories" ] | ||
| verbs: [ "*" ] |
|
All the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a "finished product", I am simply doing the bare minimum to
unblock people and make life easier while I tidy some things up.
Here I am just adding some more manifests to the
Tiltfile; I havestashed these in
tools/dev-manifestsfor now, but this may change.Either way people will not notice as they are just running
make cluster-dev.The manifests under
manifests/wego-devare technically out of use aswe move onto a Helm Chart install flow, but I am leaving them there for
now as I tinker, plus I know other people are working on the Helm bit so
I am staying out of their way.
I have also left the SuperUser and the "stripping out the service
account" bit for now, as they do not need to be in place to unblock
people. They are next on my list.
Closes #1594