fix: Update sa role to include apps/deployments #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Callisto13 appreciate this isn't strictly related to your change, but why do we need full permissions on the flux objects for a read-only UI? This seems at odds with what is described in the superuser docs https://docs.gitops.weave.works/docs/next/gitops-dashboard#login-via-an-oidc-provider cc @luizbafilho |
|
Correct, but there is no superuser in the Chart at present. I am dealing with that now. As it says in the description, this was just to unblock you. People can either take this now, or wait until I get back from holiday for me to do everything. I did not want to do all the things at once and have people waiting on me. |
|
@Callisto13 awesome - thank you, makes sense. |
JamWils
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1580
I am about to do a lot more with that Role, but this should be enough to unblock people for now.