fix: incorrect interval reported on the Sources list page #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
== UI * Utility function to convert `interval` to string, that way we have to change only in one place if we want to change the format. == Backend * Fix interval calculation on `HelmRepository` and `GitRepository`. The issues was: `.Minutes()` and `.Seconds()` return with the value of the whole interval, not just the minutes/seconds parts.
yitsushi
force-pushed
the
1589-fix-show-interval
branch
from
cf46d0e
to
c0995da
Compare
jpellizzari
reviewed
Mar 4, 2022
There was a problem hiding this comment.
@yitsushi Can you combine this logic with this component?: https://github.com/weaveworks/weave-gitops/blob/v2/ui/components/Interval.tsx
jpellizzari
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI
intervalto string, that way we have tochange only in one place if we want to change the format.
Back-end
HelmRepositoryandGitRepository.The issues was:
.Minutes()and.Seconds()return with the value ofthe whole interval, not just the minutes/seconds parts.
Closes: #1589