Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Status Icons #1622

Merged
merged 3 commits into from Mar 7, 2022
Merged

Add Status Icons #1622

merged 3 commits into from Mar 7, 2022

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Mar 4, 2022

Closes: #1584

Adds correct status icons from Figma - we are currently missing implementation for the suspended icon which is in issue #1583

image

@joshri joshri added the area/ui Issues that require front-end work label Mar 4, 2022
@joshri joshri requested a review from jpellizzari March 4, 2022 19:06
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers

/>
</svg>
<img
src=""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Probably needs to be populated, unless we are using background-image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why nothing is there - maybe because it figures out IconType on load?

@@ -0,0 +1,3 @@
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's format these. An HTML formatter should work.

@joshri joshri merged commit 8bc1e0c into v2 Mar 7, 2022
@joshri joshri deleted the 1584-status-icons branch March 7, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants