Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-work table filtering to match designs #1680

Merged
merged 5 commits into from Mar 11, 2022
Merged

Re-work table filtering to match designs #1680

merged 5 commits into from Mar 11, 2022

Conversation

jpellizzari
Copy link
Contributor

@jpellizzari jpellizzari commented Mar 10, 2022 •
edited

@jpellizzari jpellizzari marked this pull request as ready for review March 10, 2022 23:50
sympatheticmoose
sympatheticmoose approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@sympatheticmoose sympatheticmoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - approved based on video

@sympatheticmoose
Copy link
Contributor

LGTM - approved based on video

Also @jpellizzari thank you for the video to help with reviewing ⭐

joshri
joshri approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@joshri joshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ A P P R O V E D ⭐

@jpellizzari jpellizzari merged commit d5b4fe4 into v2 Mar 11, 2022
@jpellizzari jpellizzari deleted the 1618-filtering branch March 11, 2022 15:56
@bia
Copy link

bia commented Mar 14, 2022

Nice work! And thank you for posting the video @jpellizzari .

I've created follow up issue #1708 for further styling refinements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sympatheticmoose sympatheticmoose sympatheticmoose approved these changes

@joshri joshri joshri approved these changes

@bia bia Awaiting requested review from bia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpellizzari @sympatheticmoose @bia @joshri