Put explicit snyk scan workflow back #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozamosi
force-pushed
the
explicit-snyk-workflow
branch
from
f3881ca
to
38e63f4
Compare
ozamosi
force-pushed
the
explicit-snyk-workflow
branch
9 times, most recently
from
4247075
to
dd384a7
Compare
mnowster
approved these changes
Mar 11, 2022
ozamosi
force-pushed
the
explicit-snyk-workflow
branch
10 times, most recently
from
fe165c5
to
f08e63c
Compare
ozamosi
force-pushed
the
explicit-snyk-workflow
branch
2 times, most recently
from
e6f5a8c
to
a33ce4d
Compare
This replaces the webhook, because the webhook does the wrong thing: * You can't get the code scan to run using the webhook. * You also can't get snyk to look up go dependencies properly using the webhook (it uses go mod graph, which lists lots of packages that aren't part of your build, whereas the CLI uses go list, which only lists ones that are) Thus, run all the checks manually. Rather than putting them in a separate scan workflow, just put it into an appropriate part of the overall PR workflow - that is: * The static check for all checks that don't require a built docker image * A bit of extra logic dunked at the end of the docker build to scan the built image * A new, post-merge job that uploads all the things. Unfortunately, you can't (as far as I can tell) make github actions depend on a status, only jobs, so while these jobs have to run, their results aren't actually mandatory.
ozamosi
force-pushed
the
explicit-snyk-workflow
branch
from
a33ce4d
to
f33faee
Compare
|
reviewed and discussed 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the webhook, because the webhook does the
wrong thing:
webhook (it uses go mod graph, which lists lots of packages that
aren't part of your build, whereas the CLI uses go list, which only
lists ones that are)
Thus, run all the checks manually.
Rather than putting them in a separate scan workflow, just put it into
an appropriate part of the overall PR workflow - that is:
the built image
Unfortunately, you can't (as far as I can tell) make github actions
depend on a status, only jobs, so while these jobs have to run, their
results aren't actually mandatory.