Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check for readyText after it has been set #1760

Merged
merged 1 commit into from Mar 21, 2022
Merged

fix: Check for readyText after it has been set #1760

merged 1 commit into from Mar 21, 2022

Conversation

Callisto13
Copy link
Contributor

Otherwise the icon will always be red :(

@Callisto13
fix: Check for readyText after it has been set
0e4f357 
Otherwise the icon will always be red :(
@Callisto13 Callisto13 added the bug Something isn't working label Mar 21, 2022
@Callisto13 Callisto13 requested a review from joshri March 21, 2022 12:02
joshri
joshri approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@joshri joshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YIKES. Thanks for the fix Claudia

@Callisto13 Callisto13 merged commit 1658c6c into main Mar 21, 2022
@Callisto13 Callisto13 deleted the fix-ready-icon branch March 21, 2022 15:16
@Callisto13 Callisto13 mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshri joshri joshri approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Callisto13 @joshri