docs: Support staging multiple branches, remove docs front page #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozamosi
force-pushed
the
docs-per-branch
branch
17 times, most recently
from
2d4ef95
to
e85927e
Compare
added 4 commits
March 23, 2022 17:26
We use node 16 to build the main UI, so it seems more consistent to just use that here, too.
This means we can have multiple PRs that affect the docs site open at the same time, without them clobbering each other. This also adds a status check to the github checks that take you straight to the staged website. Finally, it turns off the gcp cache for the uploaded docs, because the whole point is that we want to be able to change them - the default is a 1 hour cache.
ozamosi
force-pushed
the
docs-per-branch
branch
from
e85927e
to
063779f
Compare
ozamosi
changed the title
|
thanks @ozamosi ! |
SamLR
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the staging do actual staging - that is, for this branch, the docs are in https://staging.docs.gitops.weave.works/docs-per-branch
This also adds a little status update, which you can see by scrolling through the checks in the PR and clicking on Details for "Doc site preview" that takes you to that specific URL.
This finally removes the front page of the docs, and replaces it with a redirect to the intro. I needed to make a docs change to trigger the docs pipeline to see that the previous changes worked, and this was something @sympatheticmoose specifically requested.