Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by Status #1807

Merged
merged 4 commits into from Mar 29, 2022
Merged

Sort by Status #1807

merged 4 commits into from Mar 29, 2022

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Mar 25, 2022

Closes: #1763

Clicking on the Status column of a data table will now sort by failing, then suspended, then ready

Screen.Recording.2022-03-25.at.2.08.01.PM.mov

@joshri joshri requested a review from jpellizzari March 25, 2022 18:10
@joshri joshri added the area/ui Issues that require front-end work label Mar 25, 2022
@joshri joshri marked this pull request as ready for review March 28, 2022 20:01
@joshri joshri requested a review from jpellizzari March 28, 2022 20:01
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits, LGTM.

ui/components/AutomationsTable.tsx Outdated Show resolved Hide resolved
ui/lib/utils.ts Outdated Show resolved Hide resolved
@joshri joshri merged commit 09be3f8 into main Mar 29, 2022
@joshri joshri deleted the will-i-figure-out-status branch March 29, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort by status seems to have no effect in Sources view
2 participants