Style Icon Button Hover State #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshri I see other margin changes happening here. Screenshots? |
|
@jpellizzari The margin changes are all concerning the chip group - previous version caused some alignment issues, and now the margin is applied wherever chip group is not just in the two table components. You can also see the active hover state with the circle here
|
|
As long as it looks okay without any |
jpellizzari
approved these changes
Apr 18, 2022
No chips screenshot just for the record |
This was referenced Apr 28, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1853
IconButtonstyled component can be exported for cases where the only button content is an icon, in which case we want the hover state to be a circle.Pictured - glorious circle hover state
