Display oci helm repositories well #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshri
reviewed
Jun 14, 2022
|
@joshri good catch! Fixed the tests and snapshots. |
ozamosi
force-pushed
the
oci-repositories
branch
2 times, most recently
from
d042907
to
34a28f6
Compare
opudrovs
approved these changes
Jun 15, 2022
| @@ -45,6 +44,18 @@ function HelmRepositoryDetail({ | |||
| ); | |||
| } | |||
|
|
|||
| function tryLink(url: string) { | |||
There was a problem hiding this comment.
Just a suggestion, maybe we could start adding utility/helper function return types (if not tests). Smth. like React.ReactElement<any, any> | string could work.
chanwit
reviewed
Jun 16, 2022
ozamosi
force-pushed
the
oci-repositories
branch
2 times, most recently
from
e4e9ee1
to
9b0b0a4
Compare
added 3 commits
June 22, 2022 15:36
This is done to ensure we get the new helm repository type (e.g. oci or not) passed in. I did this by `go get -u` which means there's a tonne of other upgrades included to. There's one test change, where I _think_ what happened is that a `>=` changed to `>` and thus the JWT we generated with a 1ms life started to fail instead of pass. No worries - 500ms should do it, then.
Someone (let's not git blame or point fingers - it could be any of us, really!) got confused between release and repository, and put the tests in the wrong file.
This is called "type" in flux - https://fluxcd.io/docs/components/source/helmrepositories/#type - but our frontend refers to kind as type, so I'm not taking any chances. Flux always assumes "default" when it's not "oci", according to https://github.com/fluxcd/source-controller/blob/812f6e49ddfbe42d5e11da2805b8feb9121cdb88/api/v1beta2/helmrepository_types.go#L34 This does the same thing - it means that if you run an older flux that doesn't set this field, we will still set it, and set it to a reasonable value.
ozamosi
force-pushed
the
oci-repositories
branch
3 times, most recently
from
41e6908
to
bee7694
Compare
This
* Adds the repository type to the detail page, but not to the
source table, because most pages couldn't have them.
* Removes hyperlinks from OCI URLs - this string isn't trivial to
make point to something reasonable, so I decided it's out of
scope. For example:
- ghcr.io - this link doesn't work. If you add the chart to the end
of it, it works, and if you replace ghcr.io with github.com, it
also works.
- docker.io - this link doesn't work. If you add the chart, it
still doesn't work. If you swap docker.io with hub.docker.com/r
it kinda might sometimes?
- quay.io - this link works, point at the organisation, all good.
* Removes the last updated time from OCI registries. I was confused
for a bit about this but I think it makes sense now - lastUpdated
everywhere we use it refers to the artifact's last update time. For
a regular helm repository, this is the last time we updated
index.yaml. For a git repository, it's the last time we git
pulled. In this case, there's no artifact because there is no
repository - the "chart" isn't pulled out of a repository, the chart
_is_ the docker repository and the docker image is the release. So,
when using oci repositories there's no repository sync at all,
each chart is synced individually. So there's no last time we synced.
…readcrumbs` components.
ozamosi
force-pushed
the
oci-repositories
branch
from
bee7694
to
af9bd51
Compare
chanwit
approved these changes
Jun 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the source controller, exports the helm repository type, and then displays it.
It also disables linking to oci URLs, and handles helm repositories that don't have a last updated time in both the source table and the details page - there's more details why in the UI commit.
End result:
This closes #2266