Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to highlight yaml #2378

Merged
merged 2 commits into from
Jun 29, 2022
Merged

Make it easier to highlight yaml #2378

merged 2 commits into from
Jun 29, 2022

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Jun 28, 2022

Closes #2354

Makes it easy to highlight yaml - plus there wasn't any space between the yaml view and the footer so I fixed that too :)

YamlHighlight.mov

@joshri joshri added the area/ui Issues that require front-end work label Jun 28, 2022
@joshri joshri requested a review from opudrovs June 28, 2022 17:41
@opudrovs
Copy link
Contributor

  1. @joshri works great! 🎉 Tested in Chrome and FF.

  2. I personally think that the bottom margin could be even bigger:

Screenshot 2022-06-28 at 22 31 53

  1. Would it be possible to add snapshot test(s) for the YamlView component? It's getting rather complex.

Would it be

@joshri joshri merged commit 30e4b98 into main Jun 29, 2022
@joshri joshri deleted the 2354-yaml-highlight branch June 29, 2022 13:24
This was referenced Jul 26, 2022
Merged
Merged
@weave-gitops-bot weave-gitops-bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opudrovs opudrovs opudrovs approved these changes

Assignees
No one assigned
Labels
area/ui Issues that require front-end work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text highlighting for copy paste is difficult
2 participants
@joshri @opudrovs