Add optional prometheus metrics #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozamosi
force-pushed
the
prom-endpoint
branch
4 times, most recently
from
dd90ab1
to
88a7150
Compare
If we want to be able to confidently refactor and improve the application, then we need to keep metrics on before and after. This may or may not be useful to end-users, but I definitely want this in our staging cluster, and turning it on might help debugging user environments. This pulls in a 3rd party middleware to gather RED style metrics about all of our endpoints - I see a histogram `http_request_duration_seconds` that is labeled by handler, method, and response code, I see a `http_requests_inflight` gauge labeled by handler, and a `http_response_size_bytes` histogram labeled by handler, method, and response code. This is an excellent start - I'd want the same RED metrics for k8s client requests themselves, but that can be a later problem. This resolves #2347.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to be able to confidently refactor and improve the
application, then we need to keep metrics on before and after. This
may or may not be useful to end-users, but I definitely want this in
our staging cluster, and turning it on might help debugging user
environments.
This pulls in a 3rd party middleware to gather RED style metrics about
all of our endpoints - I see a histogram
http_request_duration_secondsthat is labeled by handler, method,and response code, I see a
http_requests_inflightgauge labeled byhandler, and a
http_response_size_byteshistogram labeled byhandler, method, and response code. This is an excellent start - I'd
want the same RED metrics for k8s client requests themselves, but that
can be a later problem.
This resolves #2347.