Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to generate a secret #2419

Merged
merged 9 commits into from
Jul 14, 2022
Merged

Add command to generate a secret #2419

merged 9 commits into from
Jul 14, 2022

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Jul 8, 2022

Closes #2367

Generate a hashed secret with either:

PASSWORD=1234
echo $PASSWORD | gitops get bcrypt-hash

Or:

gitops get bcrypt-hash - will prompt you to enter your password

Tested manually by plugging a new secret value into helm-values-dev and successfully logging in! Hooray!

@joshri joshri added the type/enhancement New feature or request label Jul 8, 2022
@joshri joshri requested a review from ozamosi July 8, 2022 17:57
@ozamosi
Copy link
Contributor

ozamosi commented Jul 12, 2022

Please test manually that generated password actually lets you log in - easiest way is to put it in tools/helm-values-dev.yaml when you're using tilt. Using both password reading mechanisms.

There's a lint error about a deprecated import.

Other than that, I'd be happy to approve 🎉

@joshri joshri marked this pull request as ready for review July 12, 2022 18:25
@joshri joshri force-pushed the 2367-secret branch 2 times, most recently from 2e4d602 to 28a387f Compare July 12, 2022 18:34
@joshri joshri requested review from ozamosi and chanwit July 12, 2022 19:00
@joshri joshri merged commit 31d6938 into main Jul 14, 2022
@joshri joshri deleted the 2367-secret branch July 14, 2022 13:20
This was referenced Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CLI command to generate bcrypt for the GitOps Dashboard
3 participants