Set version flags when building release images, too #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hitting `/v1/version` against a 0.9.0 image, it returns
`{"semver":"v0.0.0","commit":"","branch":"","buildTime":""}`. This is
incorrect.
This copy-pastes bits from the dev image build process that we use to
set these properly for the staging cluster.
The footer still prints the correct thing since the javascript does
have the right versions.
ozamosi
force-pushed
the
fix-release-version
branch
from
3d3dea0
to
c84ee60
Compare
opudrovs
approved these changes
Jul 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hitting
/v1/versionagainst a 0.9.0 image, it returns{"semver":"v0.0.0","commit":"","branch":"","buildTime":""}. This isincorrect.
This copy-pastes bits from the dev image build process that we use to
set these properly for the staging cluster.
The footer still prints the correct thing since the javascript does
have the right versions.
This fixes #2370