Install GitOps Dashboard for gitops beta run #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
force-pushed
the
2358-install-gitops-dashboard-for-gitops-beta-run-new
branch
8 times, most recently
from
dab6a8c
to
26d958e
Compare
…hash. Add generating manifests for the GitOps Dashboard installation. Split `run.go` to several files.
…laying the prompt.
Add dashboard port flag. Add "Y" as a default value to the prompt.
opudrovs
force-pushed
the
2358-install-gitops-dashboard-for-gitops-beta-run-new
branch
from
26d958e
to
dd2ed42
Compare
chanwit
reviewed
Jul 22, 2022
| } | ||
|
|
||
| // IsDashboardInstalled checks if the GitOps Dashboard is installed. | ||
| func IsDashboardInstalled(log logger.Logger, ctx context.Context, kubeClient *kube.KubeHTTP) bool { |
There was a problem hiding this comment.
A small glitch here is that someone might install Weave GitOps with a different method.
But we can fix it later when needed.
There was a problem hiding this comment.
Would another method also require them to use the same HelmChart? Is it possible to install the dashboard without this HelmChart? Or will the chart be the same just its name will be different?
I mean if using a HelmChart is required for installing the dashboard can we just use something else (not the name) for detecting that this HelmChart is present reliably?
|
@chanwit great, thank you! 🌞 |
opudrovs
deleted the
2358-install-gitops-dashboard-for-gitops-beta-run-new
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2358
pkg/run/run.goto separate files, because the existing file was getting huge.--dashboard-portflag with default value 9001 and opening this port automatically for the dashboard.Notes: