display error messages when dev-ks fails #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanwit
force-pushed
the
err-msg-for-dev-ks
branch
9 times, most recently
from
41bd3c2
to
4933931
Compare
ozamosi
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
I tried running it in a way that breaks, and the output looked like:
► Request reconciliation of dev-bucket, and dev-ks (timeout 30s) ...
✗ Kustomization flux-system/flux-system: Source 'GitRepository/flux-system' not found
✗ HelmRelease flux-system/ww-gitops: install retries exhausted
✗ HelmRelease flux-system/ww-gitops: Helm install failed: rendered manifests contain a resource that already exists. Unable to continue with install: Secret "cluster-user-auth" in namespace "flux-system" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: key "app.kubernetes.io/managed-by" must equal "Helm": current value is "tilt"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "ww-gitops"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "flux-system"
Last Helm logs:
✗ GitRepository flux-system/flux-system: failed to get secret 'flux-system/flux-system': Secret "flux-system" not found
✗ Error requesting reconciliation: timed out waiting for the condition
✔ Reconciliation is done.
So it's definitely discovering the sub-object's logs and showing them. There's some odd whitespace around Last Helm Logs but I don't think that comes from us?
| @@ -164,3 +172,66 @@ func CleanupBucketSourceAndKS(log logger.Logger, kubeClient *kube.KubeHTTP, name | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| // FindConditionMessages finds the messages in the condition of objects in the inventory. | |||
| func FindConditionMessages(kubeClient *kube.KubeHTTP, ks *kustomizev1.Kustomization) ([]string, error) { | |||
There was a problem hiding this comment.
I think it would be easier to understand this function with some tests serving as examples - could we add some?
chanwit
force-pushed
the
err-msg-for-dev-ks
branch
from
4933931
to
300b135
Compare
Signed-off-by: Chanwit Kaewkasi <chanwit@weave.works>
chanwit
force-pushed
the
err-msg-for-dev-ks
branch
from
300b135
to
721a82b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2462
Signed-off-by: Chanwit Kaewkasi chanwit@weave.works