Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Cluster column forward on Sources page #2479

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Move Cluster column forward on Sources page #2479

merged 1 commit into from
Jul 22, 2022

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Jul 22, 2022

Closes #2428

Placement of the cluster column now matches AutomationsTable
image

@joshri joshri added the area/ui Issues that require front-end work label Jul 22, 2022
@joshri joshri requested review from ozamosi and opudrovs July 22, 2022 19:18
opudrovs
opudrovs approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@opudrovs opudrovs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's scary to shoulder responsibility for approving such a critical and potentially game-breaking fix on Friday night, but somebody has to do it! 💪

@joshri
Copy link
Contributor Author

joshri commented Jul 22, 2022

It's scary to shoulder responsibility for approving such a critical and potentially game-breaking fix on Friday night, but somebody has to do it! 💪

Huge. Thank you. Your hard work and sacrifice has been noticed and appreciated.

@joshri joshri merged commit a95cee5 into main Jul 22, 2022
@joshri joshri deleted the 2428-cluster-column branch July 22, 2022 20:13
@weave-gitops-bot weave-gitops-bot mentioned this pull request Jul 27, 2022
Merged
@weave-gitops-bot weave-gitops-bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opudrovs opudrovs opudrovs approved these changes

@ozamosi ozamosi Awaiting requested review from ozamosi

Assignees
No one assigned
Labels
area/ui Issues that require front-end work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move cluster column on Source Page
2 participants
@joshri @opudrovs