Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitOps Run - add compile-time variable for the Dev Bucket container image #2481

Merged
merged 1 commit into from
Jul 25, 2022
Merged

GitOps Run - add compile-time variable for the Dev Bucket container image #2481

merged 1 commit into from
Jul 25, 2022

Conversation

opudrovs
Copy link
Contributor

@opudrovs opudrovs commented Jul 24, 2022 •
edited

Closes #2461

@chanwit @ozamosi is setting the image name like this enough or should I add this variable elsewhere (Docker args, GitHub Actions workflows)?

@opudrovs opudrovs added team/denim type/enhancement New feature or request labels Jul 24, 2022
@opudrovs opudrovs marked this pull request as ready for review July 24, 2022 19:43
@opudrovs opudrovs requested review from chanwit and ozamosi July 24, 2022 19:43
@chanwit
Copy link
Member

chanwit commented Jul 25, 2022

I think it's good enough for me. WDYT @ozamosi ?

ozamosi
ozamosi approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@ozamosi ozamosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - I'd like to see some CI + release process work to get this completely automated and smooth, but this is valuable as it is for development.

@opudrovs opudrovs merged commit 5f4d207 into main Jul 25, 2022
@opudrovs opudrovs deleted the 2461-add-compile-time-variable-for-the-dev-bucket-container-image branch July 25, 2022 13:03
@weave-gitops-bot weave-gitops-bot mentioned this pull request Jul 27, 2022
Merged
@weave-gitops-bot weave-gitops-bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozamosi ozamosi ozamosi approved these changes

@chanwit chanwit chanwit approved these changes

Assignees
No one assigned
Labels
type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitOps Run - add compile-time variable for the Dev Bucket container image
3 participants
@opudrovs @chanwit @ozamosi