gitops run: Use .gitignore automatically #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many modern tools pick up ignore files automatically - tilt for example automatically picks up your dockerignore files, and rg & fd uses your gitignore files. I chose gitignore, because we're doing gitops, not dockerops. This is somewhat half-arsed: it doesn't pick up gitignore files in subdirectories, and it doesn't re-read the gitignore file properly. I assume we'll need to make this optional one day, and I assume we'll need a custom .gitopsignore one day. However until that day, this lets me run `gitops run` in the weave-gitops repository. The reason I need something like this is that my whole checkout is several GB, which made the upload take forever, and made flux refuse to do anything with it. Just parsing `.gitignore` to remove all `node_modules` quickly makes it "kinda" work. Having a node_modules directory in your application that you want to run doesn't sound terribly unlikely, so add this for now.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many modern tools pick up ignore files automatically - tilt for example automatically picks up your dockerignore files, and rg & fd uses your gitignore files. I chose gitignore, because we're doing gitops, not dockerops.
This is somewhat half-arsed: it doesn't pick up gitignore files in subdirectories, and it doesn't re-read the gitignore file properly.
I assume we'll need to make this optional one day, and I assume we'll need a custom .gitopsignore one day.
However until that day, this lets me run
gitops runin the weave-gitops repository. The reason I need something like this is that my whole checkout is several GB, which made the upload take forever, and made flux refuse to do anything with it. Just parsing.gitignoreto remove allnode_modulesquickly makes it "kinda" work.