Make automation details use getObject instead of dedicated endpoints #2751
Conversation
ui/components/AutomationDetail.tsx
Outdated
| import { useToggleSuspend } from "../hooks/flux"; | ||
| import { useGetObject } from "../hooks/objects"; | ||
| import { FluxObjectKind } from "../lib/api/core/types.pb"; | ||
| import { fluxObjectKindToKind } from "../lib/objects"; | ||
| import { getSourceRefForAutomation } from "../lib/utils"; |
There was a problem hiding this comment.
Unused import. If this function is not needed anymore since you added sourceRef getter to the classes, is it possible to remove it completely from utils and tests and replace it with the sourceRef getter in AutomationsTable and SourceDetail too?
There was a problem hiding this comment.
I see other unused imports, ah, it's because the tests have not completed yet because of the merging/rebase conflict, thought for a moment we broke eslint. 🤣
There was a problem hiding this comment.
is it possible to remove it completely from utils and tests and replace it with the sourceRef getter in AutomationsTable and SourceDetail too?
I left rewriting AutomationsTable out of this PR, so not yet.
This will also apply to FluxObjectKind and everything that uses that, which ripples through the code base, so I cut scope.
|
Tested it locally, works as expected, except for the tests. |
ozamosi
force-pushed
the
getobjects-for-automations
branch
2 times, most recently
from
3cf2d58
to
097a572
Compare
This requires adding dedicated inventory handling for helm releases - rather than redesigning the inventory handling, I added an inventory field to the object envelope and only set it when the kind is helmrelease. This isn't good, but also it works and maintains the old behaviour. There is one change in behaviour, which is that inventory read failures from the inventory secret no longer causes the object to disappear from lists or refuse to render details. It'll now show up, you just won't see any of the objects it's created. This is required for #2664 but as listObjects isn't used to list helmReleases yet, it doesn't actually resolve it.
ozamosi
force-pushed
the
getobjects-for-automations
branch
from
097a572
to
3bf9fe8
Compare
This requires adding dedicated inventory handling for helm releases - rather than redesigning the inventory handling, I added an inventory field to the object envelope and only set it when the kind is helmrelease. This isn't good, but also it works and maintains the old behaviour.
There is one change in behaviour, which is that inventory read failures from the inventory secret no
longer causes the object to disappear from lists or refuse to render details. It'll now show up, you just won't see any of the objects it's created. This is required for #2664 but as listObjects isn't used to list helmReleases yet, it doesn't actually resolve it.