Fix including pods in details pages #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
approved these changes
Sep 21, 2022
ozamosi
force-pushed
the
pods-on-details-pages
branch
from
075c0ee
to
e8965a3
Compare
Since we made the graph a tree structure internally, we've not displayed e.g. pods and replicasets on the details page, because they weren't being returned as a flat list. This changes it to work again.
ozamosi
force-pushed
the
pods-on-details-pages
branch
from
e8965a3
to
da33a4b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we made the graph a tree structure internally, we've not displayed e.g. pods and replicasets on the details page, because they weren't being returned as a flat list.
This changes it to work again.
I've tried to not make the implementation handle unexpected input, to act as a booby trap if the API were to change again. The test won't catch it, but it should make the details page break so bad you can't avoid spotting it.