Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused components #2769

Merged
merged 5 commits into from Sep 22, 2022
Merged

Remove unused components #2769

merged 5 commits into from Sep 22, 2022

Conversation

joshri
Copy link
Contributor

@joshri joshri commented Sep 21, 2022

Deletes a couple things:

  • the old hidden storybook setup directory with main.js and preview.js ./storybook
  • Modal was a relic from the storybook times
  • FancyCard I believe was meant to be part of the designs for V2 but didn't end up getting included.
    None of these are imported by Enterprise in index.ts of course 馃尀

BONUS - I got the nav to not highlight applications when you're on the notifications page. The getParentNavValue function needs to have Notifications as a valid return for the breadcrumbs, but it can't be the return for the tab value since it's not on the tabs. Long story short, it wasn't looking for null, it was looking for false.

@joshri joshri added the area/ui Issues that require front-end work label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui Issues that require front-end work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants