Update filterByTypeCallback #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshri
force-pushed
the
2959-filter-bug
branch
from
3352fcc
to
a14191d
Compare
joshri
force-pushed
the
2959-filter-bug
branch
from
a14191d
to
e9c7a8e
Compare
jpellizzari
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
Code LGTM. @joshri Why don't we need the method for reconciled objects?
ozamosi
approved these changes
Nov 7, 2022
The method was looking at a specific field - but all reconciled objects have been slotted into the FluxObject class, so we can just look at the type field and be good to go! |
joshri
force-pushed
the
2959-filter-bug
branch
from
e9c7a8e
to
421273c
Compare
This was referenced Nov 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2959
We had a special method for filtering type in the ReconciledObjectsTable that isn't needed anymore - especially since it breaks things now. Removed. I removed the specific test for it as well (we're already testing filtering type as a string from key 'type'). Also removed from exports - I checked the enterprise repo and it's not being used there so we should be good.