Protect against undefined labels in ControllersTable #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshri
force-pushed
the
2963-undefined-labels
branch
from
4b426b4
to
b54d177
Compare
ozamosi
approved these changes
Nov 7, 2022
joshri
force-pushed
the
2963-undefined-labels
branch
from
b54d177
to
d98049e
Compare
joshri
force-pushed
the
2963-undefined-labels
branch
from
d98049e
to
8e8df7b
Compare
This was referenced Nov 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2963
So I'm pretty sure this was just because I hadn't refreshed my backend in Tilt....but hey - it's good to protect against undefined anyway right? The FluxRuntime api requests should probably be returning FluxObjects at this point, but that can be addressed in a separate issue