Generate S3 server credentials on-the-fly #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
force-pushed
the
generate-secret-for-bucket-server-new
branch
2 times, most recently
from
ca47019
to
cdf9ae5
Compare
opudrovs
changed the title
opudrovs
force-pushed
the
generate-secret-for-bucket-server-new
branch
3 times, most recently
from
b9e3065
to
cb2ffcc
Compare
chanwit
previously requested changes
Dec 7, 2022
opudrovs
force-pushed
the
generate-secret-for-bucket-server-new
branch
from
cb2ffcc
to
dab0e6c
Compare
makkes
force-pushed
the
generate-secret-for-bucket-server-new
branch
from
e7049f6
to
ff16ce9
Compare
makkes
approved these changes
Dec 7, 2022
opudrovs
force-pushed
the
generate-secret-for-bucket-server-new
branch
2 times, most recently
from
1c982a1
to
1998cd8
Compare
makkes
force-pushed
the
generate-secret-for-bucket-server-new
branch
4 times, most recently
from
e4083d0
to
5eee0ae
Compare
makkes
changed the title
To improve the security of GitOps Run we now generate access and secret keys each time the `gitops beta run` command is run. These credentials are passed on to the S3 server and used in the client code for authentication.
makkes
force-pushed
the
generate-secret-for-bucket-server-new
branch
from
5eee0ae
to
75268c4
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
To improve the security of GitOps Run we now generate access and secret keys each time the
gitops beta runcommand is run. These credentials are passed on to the S3 server and used in the client code for authentication.